Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Username index out of bounds exception #WPB-12143 #3605

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 7, 2024

BugWPB-12143 [Android] Crash when creating username

https://wearezeta.atlassian.net/browse/WPB-12143

What's new in this PR?

Issues

We are doing lowercase for our username when creating an account, now if we typed two the same letters ie tt ee mm the app was crashing

Solutions

We now check if the lowercase text is different than the current one, if so we skip the update

Testing

How to Test

Open username input field view
Type two same letters tt for example
The app should not crash
Make sure that aTbZc is correctly transformed into lowercase


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-staging-compat-pr-3605.apk is available for download

@m-zagorski m-zagorski merged commit dc2d4b6 into release/candidate Nov 7, 2024
13 of 14 checks passed
@m-zagorski m-zagorski deleted the fix/username-crash-rc branch November 7, 2024 16:01
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants