fix: blank lists or flickering on Home Destinations - wrong lazyListStates [WPB-14276]

[saleniuk]

WPB-14276 [Android] Conversation screen is not visible when navigating between screens

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

When we navigate around screens sometimes the conversations are not visible until we scroll the list manually.
It looks like there are three different scenarios:
-the full list disappears for a moment when navigating back
-the list blinks quickly and then again blinks quickly when scrolling
-the list doesn't blink but then it disappears when scrolling

Causes (Optional)

Each scrollable screen from "home" graph in theory has its own LazyListState, but each view for its own purposes gets it through the currentLazyListState. Now, when app executes navigation and changes the currentNavigationItem, if the screen that's being closed still needs to recompose during the transition animation or quickly before that, then it again gets the LazyListState for itself using currentLazyListState but now it returns the LazyListState for the new screen that's being navigated to, because currentNavigationItem is already changed, so it recomposes with wrong LazyListState.

Solutions

Make each screen in the "home" graph to always and only use its dedicated LazyListState.

Thanks to that, it's finally possible to make HomeStateHolder not being remembered with key currentNavigationItem thus recreated each time the app navigates, but instead there is only one instance of it remembered and the same one is used in each screen from "home" graph.

Testing

How to Test

• Open navigation drawer
• Open settings
• Open account details
• Get back to conversation list

Attachments (Optional)

Before	After
Screen_recording_20241113_151711.mp4	fixed.mp4

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.35%. Comparing base (0390bbf) to head (b0708b3).
Report is 1 commits behind head on release/candidate.

Files with missing lines	Patch %	Lines
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt	0.00%	4 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3627      +/-   ##
=====================================================
- Coverage              45.36%   45.35%   -0.01%     
=====================================================
  Files                    471      471              
  Lines                  15843    15845       +2     
  Branches                2655     2655              
=====================================================
  Hits                    7187     7187              
- Misses                  7883     7885       +2     
  Partials                 773      773              

Files with missing lines	Coverage Δ
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0390bbf...b0708b3. Read the comment docs.

[github-actions]

Built wire-android-staging-compat-pr-3627.apk is available for download

[m-zagorski]

works great!