feat: move to folder [WPB-14627] #3787
Conversation
echoes-hq
bot
added
the
echoes: product-roadmap
| } | ||
|
|
||
| @Composable | ||
| private fun Content( |
There was a problem hiding this comment.
suggestion: I would prefer to have "content" composables without injections nor viewmodels so that previews can be created more easier, would it be complicated to move these viewmodel injections up to the ConversationFoldersScreen? 🤔
| val args = remember { | ||
| navigator.navController.currentBackStackEntry?.let { | ||
| ConversationFoldersScreenDestination.argsFrom(it) | ||
| } | ||
| } |
There was a problem hiding this comment.
suggestion: for destination composables you can get args more easily by just adding it as a parameter:
@Composable
fun ConversationFoldersScreen(
args: ConversationFoldersNavArgs,
navigator: Navigator,
resultNavigator: ResultBackNavigator<ConversationFoldersNavBackArgs>,
)
| val resources = LocalContext.current.resources | ||
| val context = LocalContext.current | ||
|
|
||
| LaunchedEffect(Unit) { |
There was a problem hiding this comment.
Should we use lifecycle.repeatOnLifecycle() here to collect only when app is in foreground?
There was a problem hiding this comment.
I think is unnecessary because even if user goes to background after triggering action it should close select folder screen either way
| private val moveConversationToFolder: MoveConversationToFolderUseCase, | ||
| ) : MoveConversationToFolderVM, ViewModel() { | ||
|
|
||
| var state: MoveConversationToFolderState by mutableStateOf(MoveConversationToFolderState()) |
There was a problem hiding this comment.
Should this be private? Or keep it public with private get() and then actionableState() is not needed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3787 +/- ##
===========================================
- Coverage 45.85% 45.77% -0.09%
===========================================
Files 483 485 +2
Lines 16510 16556 +46
Branches 2779 2781 +2
===========================================
+ Hits 7571 7578 +7
- Misses 8159 8198 +39
Partials 780 780
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3787.apk is available for download |
|
Built wire-android-dev-debug-pr-3787.apk is available for download |
|
|
Built wire-android-staging-compat-pr-3787.apk is available for download |
|
Built wire-android-dev-debug-pr-3787.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Attachments (Optional)
screen-20250107-095349.mp4