Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database logger [WPB-14608] #3798

Merged
merged 12 commits into from
Jan 15, 2025
Merged

feat: database logger [WPB-14608] #3798

merged 12 commits into from
Jan 15, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 13, 2025

StoryWPB-14608 [Android] implement database logger


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add database logger to monitor long-running quarries

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jan 13, 2025
# Conflicts:
#	app/src/main/res/values/strings.xml
#	kalium
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 15, 2025
Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (8d45505) to head (2dbd057).

Files with missing lines Patch % Lines
...in/com/wire/android/ui/debug/UserDebugViewModel.kt 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3798      +/-   ##
===========================================
- Coverage    45.77%   45.70%   -0.07%     
===========================================
  Files          485      484       -1     
  Lines        16556    16546      -10     
  Branches      2781     2781              
===========================================
- Hits          7578     7562      -16     
- Misses        8198     8204       +6     
  Partials       780      780              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <ø> (ø)
...in/com/wire/android/ui/debug/UserDebugViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d45505...2dbd057. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3798.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3798.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit b0aa25c Jan 15, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the feat/database-logger branch January 15, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants