fix: refactoring self user fetch [#WPB-15190] #3801
+99
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap
sbakhtiarov
force-pushed
the
fix/self-user-refactoring
branch
2 times, most recently
from
1b3b34d to
ce12e33
Compare
|
@sbakhtiarov looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
saleniuk
approved these changes
Jan 16, 2025
sbakhtiarov
force-pushed
the
fix/self-user-refactoring
branch
from
c9119be to
f516e21
Compare
|
MohamadJaara
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-15190
What's new in this PR?
Related to: wireapp/kalium#3229
Refactoring getting / observe self user. New
GetSelfUserUseCaseuse case to get self user is used where appropriate instead of observing until first value is received.