Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-login): new enterprise login flow - new design for welcome and email login (WPB-14337) #3807

Merged
merged 34 commits into from
Jan 21, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 20, 2025

TaskWPB-14337 [Android] - Implement UI of the initial screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Implementation of initial screen with new design
  • Only implemented for email/ password login, working flow.
  • Deeplink handling needs adjustment in designs

What's NOT this PR?

  • SSO login, for now removed, we need to bring back in a following PR
  • Deeplink navigation to custom backend, we need to remove the login background
  • Error handling of email input, we are waiting for designs a following PR will follow.

Attachments (Optional)

Screen.Recording.2025-01-10.at.18.35.58.mov

Notes

The approach we thought about this was to reuse the most we can and just accommodate, move around the pieces to fit the new workflows, so this is part of a bigger work, expected to be final in the epic PR in the end.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@yamilmedina yamilmedina changed the title feat(epic): new sso login flow - initial screen with new design feat(epic): new sso login flow - initial screen with new design (WPB-14337) Jan 20, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 20, 2025
@yamilmedina yamilmedina changed the title feat(epic): new sso login flow - initial screen with new design (WPB-14337) feat(new-login): new enterprise login flow - new design for welcome and email login (WPB-14337) Jan 20, 2025
@yamilmedina yamilmedina marked this pull request as ready for review January 20, 2025 17:48
@yamilmedina yamilmedina merged commit 9ac261d into epic/new-sso-login-flow Jan 21, 2025
12 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/newlogin-skeleton branch January 21, 2025 11:01
@yamilmedina yamilmedina restored the feat/newlogin-skeleton branch January 21, 2025 11:02
@yamilmedina yamilmedina deleted the feat/newlogin-skeleton branch January 21, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants