Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the correct screen title name [WPB-15248] #3810

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 20, 2025

BugWPB-15248 [Android] Heading on Conversation list should say "Conversations"


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

the same string for bottom sheet is used in the screen title

Solutions

Separate the 2

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

image
image
image

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 20, 2025
@MohamadJaara MohamadJaara requested review from saleniuk and Garzas and removed request for saleniuk January 20, 2025 13:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.78%. Comparing base (36b2a87) to head (290a6a5).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% 6 Missing and 1 partial ⚠️
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3810      +/-   ##
===========================================
- Coverage    45.79%   45.78%   -0.02%     
===========================================
  Files          486      486              
  Lines        16632    16638       +6     
  Branches      2792     2797       +5     
===========================================
  Hits          7617     7617              
- Misses        8234     8239       +5     
- Partials       781      782       +1     
Files with missing lines Coverage Δ
...kotlin/com/wire/android/ui/home/HomeStateHolder.kt 0.00% <0.00%> (ø)
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b2a87...290a6a5. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3810.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3810.apk is available for download

@ohassine ohassine added this pull request to the merge queue Jan 22, 2025
Merged via the queue into develop with commit a71af95 Jan 22, 2025
14 checks passed
@ohassine ohassine deleted the fix/conversation-label branch January 22, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants