Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust new login skeleton to edge-to-edge [WPB-14337] #3812

Merged
merged 5 commits into from
Jan 21, 2025
Merged

feat: adjust new login skeleton to edge-to-edge [WPB-14337] #3812

merged 5 commits into from
Jan 21, 2025

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 20, 2025 •
edited by github-actions bot
Loading

TaskWPB-14337 [Android] - Implement UI of the initial screen

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added a way of creating previews with system bars that handle edge-to-edge properly
  • created new styles for navigation destinations to be able to choose the background for the given screen and moved applying splash background to WireActivity where navigation and topbar are implemented
  • added handling background colors for status and navigation bars properly when splash or default background is set for the given screen
  • fixed transitions, mainly between welcome and login screen

topbar_previews

new_login_flow_1_edgetoedge.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 20, 2025
@saleniuk
Merge remote-tracking branch 'refs/remotes/origin/feat/newlogin-skele…
0626621 
…ton' into feat/newlogin-skeleton-edgetoedge

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/authentication/login/LoginScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/authentication/login/NewLoginContainer.kt
#	app/src/main/kotlin/com/wire/android/ui/authentication/login/WireAuthBackgroundComponent.kt
#	app/src/main/kotlin/com/wire/android/ui/authentication/start/StartLoginScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/authentication/welcome/WelcomeScreen.kt
@saleniuk
fixes after resolving merge conflicts
9c3a300
@saleniuk saleniuk requested a review from yamilmedina January 20, 2025 17:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Base automatically changed from feat/newlogin-skeleton to epic/new-sso-login-flow January 21, 2025 11:01
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@yamilmedina yamilmedina changed the base branch from epic/new-sso-login-flow to feat/newlogin-skeleton January 21, 2025 11:02
Base automatically changed from feat/newlogin-skeleton to epic/new-sso-login-flow January 21, 2025 11:08
@saleniuk saleniuk requested review from a team, typfel, sbakhtiarov, borichellow, ohassine and emmaoke-w and removed request for a team January 21, 2025 11:21
@saleniuk saleniuk merged commit 5bf9049 into epic/new-sso-login-flow Jan 21, 2025
12 of 13 checks passed
@saleniuk saleniuk deleted the feat/newlogin-skeleton-edgetoedge branch January 21, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@Garzas Garzas Garzas approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@sbakhtiarov sbakhtiarov Awaiting requested review from sbakhtiarov sbakhtiarov was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@emmaoke-w emmaoke-w Awaiting requested review from emmaoke-w emmaoke-w was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saleniuk @yamilmedina @Garzas