Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create and share obfuscated user database [WPB-14826] #3818

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 22, 2025

BugWPB-14826 [Android] Conversation list loading very slow after closing a conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

sometimes internally it is needed to debug the local user database

Solutions

  1. create empty file
  2. use sqlCipher export function to create unencrypted copy
  3. use the same code as backup to encrypt and share the file

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
01522be6baa8f918cc93834ab12b45d653168ed8 7820b6ef5ac3f2b42511cb3d190229b99484b2ad

Is this intentional?

Copy link
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
01522be6baa8f918cc93834ab12b45d653168ed8 7820b6ef5ac3f2b42511cb3d190229b99484b2ad

Is this intentional?

Copy link
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
01522be6baa8f918cc93834ab12b45d653168ed8 7820b6ef5ac3f2b42511cb3d190229b99484b2ad

Is this intentional?

@MohamadJaara MohamadJaara changed the title feat: create and share obfuscated user database feat: create and share obfuscated user database [WPB-14826] Jan 27, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 45.28%. Comparing base (3b4eaad) to head (c94540b).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/ui/debug/ExportObfuscatedCopyViewModel.kt 0.00% 43 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3818      +/-   ##
===========================================
- Coverage    45.45%   45.28%   -0.17%     
===========================================
  Files          490      491       +1     
  Lines        16889    16952      +63     
  Branches      2832     2844      +12     
===========================================
  Hits          7677     7677              
- Misses        8426     8489      +63     
  Partials       786      786              
Files with missing lines Coverage Δ
...d/ui/home/settings/backup/BackupAndRestoreState.kt 100.00% <ø> (ø)
.../android/ui/debug/ExportObfuscatedCopyViewModel.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4eaad...c94540b. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 29, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3818.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3818.apk is available for download

Merged via the queue into develop with commit c1ff13b Jan 29, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the chore/conversation-loading-playground branch January 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants