Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add is team member segmentation to app.open event (WPB-14523) #3841

Merged
merged 6 commits into from
Jan 28, 2025
Merged

feat: Add is team member segmentation to app.open event (WPB-14523) #3841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a33b755
feat: add is_team_member and user_type segmentations
ohassine Jan 27, 2025
65a0d10
chore: unit test
ohassine Jan 27, 2025
35325a2
feat: add isTeamMember segmentation to app.open event
ohassine Jan 27, 2025
465c6c6
Merge remote-tracking branch 'origin/develop' into add-is-team-member…
ohassine Jan 28, 2025
56a24d3
feat: detekt
ohassine Jan 28, 2025
0288afb
Merge branch 'develop' into add-is-team-member-segmentation-to-app.op…
ohassine Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/src/main/kotlin/com/wire/android/WireApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,16 @@ class WireApplication : BaseApp() {
.isAppVisibleFlow()
.filter { isVisible -> isVisible }
.collect {
AnonymousAnalyticsManagerImpl.sendEvent(AnalyticsEvent.AppOpen)
val currentSessionResult = coreLogic.get().getGlobalScope().session.currentSessionFlow().first()
val isTeamMember = if (currentSessionResult is CurrentSessionResult.Success) {
coreLogic.get().getSessionScope(currentSessionResult.accountInfo.userId).team.isSelfATeamMember()
} else {
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about null, maybe false? If user is not logged in - user is not in a team :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pass false, it means we have a personal user logged in. So better to keep undefined and pass null to not send isTeamMember segmentation at all if there is no user logged in.

}

AnonymousAnalyticsManagerImpl.sendEvent(
AnalyticsEvent.AppOpen(isTeamMember)
)
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,13 @@ interface AnalyticsEvent {
*/
fun toSegmentation(): Map<String, Any> = mapOf()

data object AppOpen : AnalyticsEvent {
data class AppOpen(val isTeamMember: Boolean?) : AnalyticsEvent {
override val key: String = AnalyticsEventConstants.APP_OPEN
override fun toSegmentation(): Map<String, Any> {
return isTeamMember?.let {
mapOf(IS_TEAM_MEMBER to it)
} ?: super.toSegmentation()
}
}

/**
Expand Down
Loading