feat: move conversation to folder from other user profile [WPB-15479] [WPB-14630] #3849
+133
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
|
ohassine
reviewed
Jan 29, 2025
| onMoveToFolder: (ConversationFoldersNavArgs) -> Unit = {}, | ||
| initialPageIndex: GroupConversationDetailsTabItem = GroupConversationDetailsTabItem.OPTIONS, | ||
| changeConversationFavoriteStateViewModel: ChangeConversationFavoriteVM = | ||
| hiltViewModelScoped<ChangeConversationFavoriteVMImpl, ChangeConversationFavoriteVM, ChangeConversationFavoriteStateArgs>( | ||
| ChangeConversationFavoriteStateArgs | ||
| ), | ||
| removeConversationFromFolderVM: RemoveConversationFromFolderVM = |
There was a problem hiding this comment.
what VM refers to ? better to use full name than abbreviation
There was a problem hiding this comment.
it's because it's hard to fit to the max line with this view model argument
yamilmedina
approved these changes
Jan 30, 2025
yamilmedina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Attachments (Optional)
screen-20250129-135252.mp4