Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move conversation to folder from other user profile [WPB-15479] [WPB-14630] #3849

Merged
merged 5 commits into from
Jan 30, 2025
Merged

feat: move conversation to folder from other user profile [WPB-15479] [WPB-14630] #3849

merged 5 commits into from
Jan 30, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 29, 2025 •
edited by github-actions bot
Loading

TaskWPB-15479 [Android] Allow 1:1 conversations to be moved from user profile to folder

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • implemented add/remove 1on1 conversation from favorites in other user profile
  • implemented move/remove 1on1 conversation to folder in other user profile
  • implemented snackbar messages about folders in conversation details screen

Attachments (Optional)

screen-20250129-135252.mp4

@Garzas Garzas self-assigned this Jan 29, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 29, 2025
ohassine
ohassine reviewed Jan 29, 2025
View reviewed changes
...main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsScreen.kt
onMoveToFolder: (ConversationFoldersNavArgs) -> Unit = {},
initialPageIndex: GroupConversationDetailsTabItem = GroupConversationDetailsTabItem.OPTIONS,
changeConversationFavoriteStateViewModel: ChangeConversationFavoriteVM =
hiltViewModelScoped<ChangeConversationFavoriteVMImpl, ChangeConversationFavoriteVM, ChangeConversationFavoriteStateArgs>(
ChangeConversationFavoriteStateArgs
),
removeConversationFromFolderVM: RemoveConversationFromFolderVM =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what VM refers to ? better to use full name than abbreviation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because it's hard to fit to the max line with this view model argument

@yamilmedina yamilmedina changed the title feat: move conversation to folder from other user profile [WPB-15479, WPB-14630] feat: move conversation to folder from other user profile [WPB-15479] [WPB-14630] Jan 30, 2025
@Garzas Garzas requested a review from ohassine January 30, 2025 11:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.19%. Comparing base (4f5fb2b) to head (5960905).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3849   +/-   ##
========================================
  Coverage    45.19%   45.19%           
========================================
  Files          491      491           
  Lines        16988    16989    +1     
  Branches      2844     2845    +1     
========================================
+ Hits          7677     7678    +1     
  Misses        8527     8527           
  Partials       784      784
Files with missing lines Coverage Δ
...re/android/ui/connection/ConnectionActionButton.kt 0.00% <ø> (ø)
...erprofile/other/OtherUserProfileScreenViewModel.kt 59.90% <100.00%> (+0.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5fb2b...5960905. Read the comment docs.

@Garzas Garzas added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 5fd7ef4 Jan 30, 2025
13 of 14 checks passed
@Garzas Garzas deleted the feat/other-user-profile-move-to-folder branch January 30, 2025 14:17
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3849.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3849.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@saleniuk saleniuk saleniuk approved these changes

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @codecov-commenter @yamilmedina @ohassine @saleniuk