Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alert on backup failure - WPB-15211 #2387

Draft
wants to merge 131 commits into
base: epic/prepare-for-universal-backups-WPB-14616
Choose a base branch
from
Draft

fix: alert on backup failure - WPB-15211 #2387

wants to merge 131 commits into from
+1,453 −480

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 14, 2025 •
edited by github-actions bot
Loading

TaskWPB-15211 [iOS] Update the UI for backup export

Issue

This PR aims to fix a few issues, like:

  • Any alert reporting an error on backup is dismissed immediately
  • tbc

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

KaterinaWire and others added 30 commits January 2, 2025 08:20
@KaterinaWire
feat: add BackupViewMode and new stringsl
5ff6f05
@KaterinaWire
feat: add WireBackupUI
d4a21e1
@KaterinaWire
feat: add SetBackupPassword
a768468
@KaterinaWire
move to WireSettingsUI
85c5107
@KaterinaWire
add Localizable
7a74f68
@KaterinaWire
Merge branch 'develop' into feat/new-backup-export-UI-WPB-15211
c9c546c
@KaterinaWire
move all files to WireUI
832f44d
@KaterinaWire
add strings
7aa58ba
@KaterinaWire
Merge branch 'develop' into feat/new-backup-export-UI-WPB-15211
3cc4b5b
@KaterinaWire
remove files
2a46189
@KaterinaWire
clean up
beac109
@KaterinaWire
add BackupHandler
ab35e0f
@KaterinaWire
remove ToDos
dc2836a
@KaterinaWire
add BackupPasswordValidator
33d009d
@KaterinaWire
fix SwiftFormat issues
5557bf9
@KaterinaWire
UI for backup restore
a4a70de
@KaterinaWire
remove old backup code
3d89bfb
@KaterinaWire
Merge branch 'develop' into feat/new-backup-export-UI-WPB-15211
0e4c65a
@KaterinaWire
fix SwiftFormat issues
a2761c3
@KaterinaWire
Merge branch 'develop' into feat/new-backup-export-UI-WPB-15211
270f041
@KaterinaWire
fix SwiftLint issues
f0bdfc7
@KaterinaWire
fix SwiftFormat issues
def2495
@KaterinaWire
fix SwiftFormat issues
f98c390
@caldrian
attempt to fix linker errors
52c51ec
@KaterinaWire
remove BackupPasswordViewControllerTests and BackupViewControllerTests
7628212
@KaterinaWire
fix dada model tests
e2dfc6f
@KaterinaWire @caldrian
Update WireUI/Sources/WireSettingsUI/Account/Backup/Protocols/BackupP…
5eaaa40 
…asswordValidator.swift

Co-authored-by: Christoph Aldrian <[email protected]>
@KaterinaWire @caldrian
Update WireUI/Sources/WireSettingsUI/Resources/en.lproj/Accessibility…
25776e3 
….strings

Co-authored-by: Christoph Aldrian <[email protected]>
@KaterinaWire @caldrian
Update WireUI/Sources/WireSettingsUI/Account/Backup/Models/BackupHand…
57975f8 
…ler.swift

Co-authored-by: Christoph Aldrian <[email protected]>
@KaterinaWire @caldrian
Update WireUI/Sources/WireSettingsUI/Account/Backup/ViewControllers/B…
1ea4744 
…ackupActionsHostingController.swift

Co-authored-by: Christoph Aldrian <[email protected]>
@caldrian caldrian force-pushed the fix/backup-export-alert-WPB-15211 branch from 959863e to 8ba9555 Compare January 15, 2025 08:37
caldrian added 25 commits January 15, 2025 10:03
@caldrian
fix build errors
b702ea3
@caldrian
move close button icon into reusable components
2935b16
@caldrian
fix build errors
07a037d
@caldrian
use modifier for accessibilityLabel
9f52d74
@caldrian
update packages
61b64f0
@caldrian
use close button in Wire-iOS
de88a3c
@caldrian
Merge branch 'refactor/close-button-WPB-15211' into fix/backup-export…
9b375ae 
…-alert-WPB-15211
@caldrian
combine views
5c34093
@caldrian
format code
8a002bd
@caldrian
add TODO
8a8c87f
@caldrian
rename and move files
a487e2a
@caldrian
create ImportBackupViewModel
882b01f
@caldrian
prepare for injecting ImportBackupView into BackupRestoreView
b4773fc
@caldrian
prepare more refactoring
a79d02c
@caldrian
prepare fixing crash on iPad
5df3ff6
@caldrian
add TODO
4abb76a
@caldrian
revert a few changes of the epic branch
555ba12
@caldrian
present activity view controller on iPhone
8b78151
@caldrian
more refactoring
fc33103
@caldrian
trial&error
c002585
@caldrian
finish backup for iPhone
d1f3c2c
@caldrian
attempt to present the popover via UIViewRepresentable
02d7010
@caldrian
fix popover presentation for iPad
dee7870
@caldrian
add comment
d64d8cf
@caldrian
minor change
5bfbde0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caldrian caldrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caldrian @KaterinaWire