Force status refresh on target and action request #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwendalRaoul
reviewed
Feb 3, 2025
| @@ -1058,7 +1058,7 @@ app_proto_res_e Proto_config_handle_set_scratchpad_target_and_action_request( | |||
| param); | |||
|
|
|||
| // Read otap variable back to be sure everything is updated | |||
| initialize_otap_variables(); | |||
| Proto_config_refresh_otap_infos(); | |||
There was a problem hiding this comment.
Shouldn't it be moved in the else of the if (res != APP_RES_OK) ?
Value is changed only if APP_RES8OK is returned. ANd it would allow to call Proto_config_refresh_otap_infos only one time
StephaneTriomphe
force-pushed
the
fix/refresh_status_on_target_and_action_request
branch
from
ef973f6 to
efe48be
Compare
GwendalRaoul
approved these changes
Feb 3, 2025
StephaneTriomphe
deleted the
fix/refresh_status_on_target_and_action_request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.