LG-73 Partial CDD API support #133
Open
+301
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes support for the following: - Setting an item (WPC_set_config_data_item) - Getting an item (WPC_get_config_data_item) - Registering a callback for an item indication (WPC_register_for_config_data_item)
sgunes-wirepas
commented
Feb 21, 2025
| * Size of the payload that was written to the above pointer (bytes) | ||
| * \return Return code of the operation | ||
| */ | ||
| app_res_e WPC_get_config_data_item(const uint16_t endpoint, |
There was a problem hiding this comment.
This currently kind of forces the caller to allocate a payload array with size UINT8_MAX. Do you think that's too much? Right now max size in dualmcu interface is 80 bytes.
If we want to optimize this, we can add a size check here so the caller would pass allocated buffer size to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support for the following: