feat(viewer): detect mathml expression with break lines #1068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering formulas with the viewer, if the MathML is broken by line breaks, tabs, or other special characters, it cannot be recognized as valid MathML and thus will not trigger showimage to render it.
This commit modifies the regex used to identify MathML, allowing it to tolerate the presence of such special characters within the MathML content.
Type of Change
Checklist
yarn lint
to check)How should be tested? (Manual or Automated Tests)
You can have the follow doc as example: render it with viewer in the production (https://integrations.wiris.kitchen/master/html/viewer/) you may see some equations are not rendered.
Then you can try with current viewer, you can see they are rendered properly