Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 year in review #1369

Merged
merged 39 commits into from
Jan 17, 2025
Merged

2024 year in review #1369

merged 39 commits into from
Jan 17, 2025

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Jan 14, 2025

2024 Year in review guest blog post by Shinya!

  • original text copied over
  • original images (formatted to webp, using <BlogImage /> component
  • use Video component for embedded YouTube videos
  • embedded social media posts (are we using astro-embed or <blockquote>?)
  • code samples formatted (proper language, title attributes for Expressive Code)
  • Shinya added as author (authors.json + GH avatar)
  • remove absolute links back to this blog
  • add <ShowcaseCard> for appropriate external links, possibly???
  • finalize title and description
  • Sarah: write guest post introduction
  • Chris: create social/cover images and update frontmatter
  • decide publication date
  • LOTS OF PROOFREADING!!

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit c067675
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/678a4ce5eb2e5c0008b2e496
😎 Deploy Preview https://deploy-preview-1369--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
5 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 95 (🟢 up 3 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918
Copy link
Member Author

sarah11918 commented Jan 15, 2025

@morinokami - I'll be working on an introduction (and more proofreading etc.) today, but would love for you to review this before it's published!

So, I'll make commits with edits in sections, and then whenever you're available to review my edits, that would be great! 🙌

UPDATE: These edits are ready for you to review now!
Specific commits to review:

Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 Thank you for updating my article! The updated version looks awesome, and I learned a lot from your edits. I left a few small fixes for some typos (which I created 😅).

src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say, great article! 🙌🏽 I just left a few comments.

src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @morinokami and @sarah11918! I left a last few notes, but this is a lovely read — grateful to you for putting it together 💜

src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
src/content/blog/year-in-review-2024.mdx Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918 sarah11918 merged commit 91337c5 into main Jan 17, 2025
6 checks passed
@sarah11918 sarah11918 deleted the year-in-review-2024 branch January 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants