Updating weekly scripts to clean up the PR process #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tony-sull
commented
Jan 25, 2024
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Run update:themes script |
There was a problem hiding this comment.
all theme updates are safe since we manually add/remove them, moved this into the nightly job
tony-sull
commented
Jan 25, 2024
| const details = await fetchWithOverrides(data.name) | ||
| // skipping download counts here since existing integrations will be updated | ||
| // automatically in a separate GitHub Action. | ||
| const details = await fetchWithOverrides(data.name, false) |
There was a problem hiding this comment.
This is here to make sure the PR that requires manual review won't update every single integration with a new downloads counter
tony-sull
commented
Jan 25, 2024
|
|
||
| // only fetch unsafe changes like new and deprecated integrations | ||
| // if the --unsafe CLI flag was provided | ||
| if (args.includes("--unsafe")) { |
There was a problem hiding this comment.
This flag is included in the weekly GitHub Action only, nightly will run safe migrations only
ElianCodes
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the weekly GitHub Action to only include unsafe content changes that need manual review.
For safe content updates, like GitHub stars for existing themes or NPM download stats for existing integrations, those now get updated in a nightly script that auto-commits updates to the repo.