Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blog): Article for 4.4 #986

Merged
merged 7 commits into from
Feb 15, 2024
Merged

feat(blog): Article for 4.4 #986

merged 7 commits into from
Feb 15, 2024

Conversation

Princesseuh
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-build ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 0:04am

ematipico
ematipico approved these changes Feb 14, 2024
View reviewed changes
src/content/blog/astro-440.mdx Show resolved Hide resolved
src/content/blog/astro-440.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-440.mdx Outdated Show resolved Hide resolved
ElianCodes
ElianCodes reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Excited for inferSize

src/content/blog/astro-440.mdx Outdated Show resolved Hide resolved
@Princesseuh @ElianCodes @sarah11918
Apply suggestions from code review
cb77df9 
Co-authored-by: Elian <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
delucis
delucis approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro nit from me, but the whole post reads really well — great job!

Also noting that the OG and hero images still need updating to a centred version!

src/content/blog/astro-440.mdx Outdated Show resolved Hide resolved
yanthomasdev
yanthomasdev approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Princesseuh Princesseuh merged commit 79d7c18 into main Feb 15, 2024
3 checks passed
@Princesseuh Princesseuh deleted the feat/astro-440 branch February 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElianCodes ElianCodes ElianCodes left review comments

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@ematipico ematipico ematipico approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Princesseuh @delucis @ematipico @sarah11918 @ElianCodes @yanthomasdev