fix(i18n): server island request #13112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ead785 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13112 will not alter performanceComparing Summary
|
ematipico
force-pushed
the
fix/server-island-i18n
branch
from
97956c0 to
01cb6d0
Compare
ematipico
force-pushed
the
fix/server-island-i18n
branch
from
01cb6d0 to
5ead785
Compare
ascorbic
approved these changes
Jan 31, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12817
The i18n middleware now checks if the request is coming from a server island, and if so, it doesn't handle it.
Also did a minor refactor to move some utility functions in the proper file.
Testing
I added a new test with a new fixture to not tarnish the existing ones. I also tested it locally using OP reproduction. It now serves the island correctly.
Docs
N/A