Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression parsing in foreign context #1062

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Trombach
Copy link

@Trombach Trombach commented Feb 2, 2025

Changes

This PR adds the current Namespace to the expression Node.

When writing an expression inside foreign content (i.e. SVG) the astro compiler did not persist the namespace and therefore parsed the contained nodes in normal HTML mode. This lead to <image> tags incorrectly being transformed to <img> tags, but could also have caused other Problems.

Testing

  • added printer test to validate correct parsing of {<image />} inside svg

Docs

bug fix only

Copy link

changeset-bot bot commented Feb 2, 2025

🦋 Changeset detected

Latest commit: a30bd42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating <image /> elements inside an <svg> ends up with <img /> outside
1 participant