Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content treated as string after JSX comment inside expression #895

Merged
merged 19 commits into from
Dec 20, 2023

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Nov 23, 2023

Changes

Partial fix for #609

Fix the issues where HTML and JSX comments lead to subsequent content being incorrectly treated as plain text when they have parent expressions.

#897 will fix the final issue mentioned in #609 which is kind of unrelated to JSX comments being used, but expressions in general

Testing

Added printer test for each case mentioned in the issue

Docs

N/A bug fix

Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 3f2d095

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MoustaphaDev MoustaphaDev marked this pull request as ready for review November 23, 2023 17:24
@MoustaphaDev MoustaphaDev changed the title Fix lately terminated strings caused by expressions Fix content treated as string after JSX comment inside expression Nov 23, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the changeset to match the verb tense we're standardizing on! 🙌

.changeset/lazy-beers-develop.md Outdated Show resolved Hide resolved
@MoustaphaDev MoustaphaDev marked this pull request as draft December 14, 2023 20:53
@MoustaphaDev MoustaphaDev marked this pull request as ready for review December 18, 2023 11:06
@MoustaphaDev
Copy link
Member Author

!preview err-jsx-comments-in-expr

Copy link
Contributor

 > [email protected] release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--err-jsx-comments-in-expr" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--err-jsx-comments-in-expr tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-err-jsx-comments-in-expr-20231218110825) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-err-jsx-comments-in-expr-20231218110825" 🦋 success packages published successfully: 🦋 @astrojs/[email protected] 🦋 Creating git tag... 🦋 New tag: @astrojs/[email protected]

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@natemoo-re natemoo-re merged commit 4f74c05 into main Dec 20, 2023
5 checks passed
@natemoo-re natemoo-re deleted the fix-comments-bugs branch December 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants