-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content treated as string after JSX comment inside expression #895
Conversation
🦋 Changeset detectedLatest commit: 3f2d095 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating the changeset to match the verb tense we're standardizing on! 🙌
Co-authored-by: Sarah Rainsberger <[email protected]>
!preview err-jsx-comments-in-expr |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the PR!
Changes
Partial fix for #609
Fix the issues where HTML and JSX comments lead to subsequent content being incorrectly treated as plain text when they have parent expressions.
#897 will fix the final issue mentioned in #609 which is kind of unrelated to JSX comments being used, but expressions in general
Testing
Added printer test for each case mentioned in the issue
Docs
N/A bug fix