-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multibyte character handling #906
Conversation
🦋 Changeset detectedLatest commit: acf9fe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
963208f
to
ce387aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be tackled separately just to fix the crash, however it'd be great to have a sourcemap test with multi bytes characters to make sure this didn't break stuff!
8322298
to
d107072
Compare
@Princesseuh Added some sourcemap-specific tests in 525b6cc! Everything seems to be working well. |
Testing JS sourcemaps with the annotations would be great since the bug started there! But it's great that it works for TSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes
len()
check before access the index, which guards against the issue.Testing
Tests added for cases that have been reported to throw
Docs
Bug fix only