Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multibyte character handling #906

Merged
merged 12 commits into from
Dec 15, 2023
Merged

Fix multibyte character handling #906

merged 12 commits into from
Dec 15, 2023

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Tests added for cases that have been reported to throw

Docs

Bug fix only

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: acf9fe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be tackled separately just to fix the crash, however it'd be great to have a sourcemap test with multi bytes characters to make sure this didn't break stuff!

@natemoo-re
Copy link
Member Author

@Princesseuh Added some sourcemap-specific tests in 525b6cc! Everything seems to be working well.

@Princesseuh
Copy link
Member

@Princesseuh Added some sourcemap-specific tests in 525b6cc! Everything seems to be working well.

Testing JS sourcemaps with the annotations would be great since the bug started there! But it's great that it works for TSX

Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natemoo-re natemoo-re merged commit 5b450df into main Dec 15, 2023
5 checks passed
@natemoo-re natemoo-re deleted the fix/emoji branch December 15, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants