Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template literal attributes on components #918

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

MoustaphaDev
Copy link
Member

Changes

Fix #903
Components with template literal attributes were printed with the attribute name as value.

Testing

Added a printer test

Docs

N/A bug fix

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 8e76680

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MoustaphaDev MoustaphaDev changed the title Fix Fix template literal attributes on components Dec 21, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@MoustaphaDev MoustaphaDev merged commit cad2606 into main Dec 21, 2023
5 checks passed
@MoustaphaDev MoustaphaDev deleted the fix-template-literal-attr branch December 21, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class with template string breaks when HTML tag is variable
2 participants