Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: vtt_create_bloc #362

Closed
wants to merge 3 commits into from
Closed

refactor: vtt_create_bloc #362

wants to merge 3 commits into from

Conversation

parodyBit
Copy link
Contributor

separate the logic for building transactions apart from the UI BLOC actions.

@parodyBit parodyBit force-pushed the rafctor-vtt_create_bloc branch 2 times, most recently from 46509ac to 3e20164 Compare September 8, 2023 02:41
gabaldon
gabaldon requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@gabaldon gabaldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is an error validating the estimated fees and amount when not enough funds

lib/util/storage/database/wallet.dart Outdated Show resolved Hide resolved
lib/bloc/transactions/transaction_builder.dart Outdated Show resolved Hide resolved
lib/widgets/witnet/transactions/value_transfer/create_dialog_box/qr_scanner.dart Outdated Show resolved Hide resolved
...gets/witnet/transactions/value_transfer/create_dialog_box/vtt_builder/01_recipient_step.dart Outdated Show resolved Hide resolved
@parodyBit parodyBit marked this pull request as ready for review October 2, 2023 13:43
@parodyBit parodyBit requested a review from gabaldon October 2, 2023 14:04
@parodyBit parodyBit force-pushed the rafctor-vtt_create_bloc branch from 4743995 to b2afbb9 Compare October 2, 2023 17:44
gabaldon
gabaldon requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@gabaldon gabaldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error sending transactions, it could not be executed due to wrong params.

@parodyBit parodyBit force-pushed the rafctor-vtt_create_bloc branch from b2afbb9 to f3a64fe Compare October 26, 2023 02:32
@parodyBit parodyBit force-pushed the rafctor-vtt_create_bloc branch from f3a64fe to 7b4fe4f Compare November 14, 2023 03:54
@parodyBit
refactor: vtt_create_bloc
5b89117 
separate the logic for building transactions apart from the UI BLOC actions.
@parodyBit
refactor: use UtxoList extension
dfe3609
@parodyBit parodyBit force-pushed the rafctor-vtt_create_bloc branch from 7b4fe4f to dfe3609 Compare November 14, 2023 04:02
@parodyBit
fix: codestyle
c056bf4 
remove unused var
@parodyBit parodyBit requested a review from gabaldon November 14, 2023 11:51
@gabaldon
Copy link
Contributor

Not relevant anymore

@gabaldon gabaldon closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabaldon gabaldon Awaiting requested review from gabaldon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parodyBit @gabaldon