Feat/esm #104
Merged
Feat/esm #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
.github/workflows/ci.yaml needs upgrading node version to 20 |
Tommytrg
force-pushed
the
feat/esm
branch
4 times, most recently
from
74fdccf to
4f93f4d
Compare
guidiaz
requested changes
Feb 1, 2024
src/i18n.ts
Outdated
| import en from './locales/en.json' | ||
| import es from './locales/es.json' | ||
| import en from "./locales/en.json" assert { type: "json" }; | ||
| import es from "./locales/es.json" assert { type: "json" }; |
There was a problem hiding this comment.
Import JSON this other way, as to avoid CLI tools using witnet-radon-js to stream out "(node:12542) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time" into STDERR:
import { createRequire } from "module";
const require = createRequire(import.meta.url);
const en = require("./locales/en.json");
const es = require("./locales/es.json");
guidiaz
approved these changes
Feb 1, 2024
Tommytrg
force-pushed
the
feat/esm
branch
2 times, most recently
from
25f7363 to
a825cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #103