Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWI: display_address #55

Merged
merged 3 commits into from
Nov 17, 2023
Merged

HWI: display_address #55

merged 3 commits into from
Nov 17, 2023

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Nov 13, 2023

No description provided.

@edouardparis edouardparis force-pushed the verify-address branch 3 times, most recently from 84f2a1a to 9eb4295 Compare November 15, 2023 12:16
This method is confusing and not trivial to properly
implement. A device can be busy and not respond immediatly
but still is connected.

API user should use hidapi list device and
check if device with same product id and vendor id is present.
@edouardparis edouardparis force-pushed the verify-address branch 2 times, most recently from c691fcf to 382098d Compare November 15, 2023 14:14
@edouardparis edouardparis marked this pull request as ready for review November 15, 2023 17:02
edouardparis added a commit to edouardparis/liana that referenced this pull request Nov 15, 2023
the method was deleted from HWI trait.
See wizardsardine/async-hwi#55
commit: 0c78a2fdf44a637ec8a769ad5a7d74398b16c16c
@edouardparis edouardparis merged commit d62ace4 into master Nov 17, 2023
7 checks passed
@edouardparis edouardparis deleted the verify-address branch November 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant