Export descriptor #1551
Export descriptor #1551
Conversation
| let date = chrono::Local::now().format("%Y-%m-%dT%H-%M-%S"); | ||
| format!("liana-txs-{date}.csv") | ||
| } | ||
| ExportType::Psbt(_) => "psbt.psbt".into(), |
There was a problem hiding this comment.
what do you think about {txid}.psbt ? cc @nondiremanuel @jp1ac4 ?
There was a problem hiding this comment.
the complete txid is quite long imho, maybe {txid[..10]}.psbt ?
There was a problem hiding this comment.
Possibly having the full txid would make it easier to search for the file, but otherwise I think the short version should be fine.
There was a problem hiding this comment.
windows path are limited to 260 chars iirc, its not likely to hit this, but....
There was a problem hiding this comment.
I would prioritize not hitting the limit, so if there is that risk maybe we should truncate the id to a safe number of chars.
There was a problem hiding this comment.
for info, i looked a sparrow, it's default name is the label of the first output (output labels are mandatory in sparrow):
<label>.psbt
There was a problem hiding this comment.
label would be nice, but we would have to choose something for non labeled psbts. I was also thinking that txid (or truncated txid) could be seen just as a random string to non-technical users, so maybe it's not the best solution.
pythcoiner
force-pushed
the
export_descriptor
branch
from
28cd582 to
5e3c565
Compare
No description provided.