upgrade bitcoin dependency to 0.32 and related #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, the upgrade to the latest bdk_electrum crate is done in d7e72cb. |
|
I'll need to investigate the failure of test_spend.py::test_coin_selection. I haven't had any failures locally, but I'll try again with the same bitcoind/electrs version as used by CI. |
I can't reproduce the failing test locally even with the same bitcoind and electrs versions as used by CI. |
This upgrades bitcoin to 0.32 and related dependencies accordingly. Note that the bdk_electrum crate has not been upgraded to the most recent version available as the Electrum syncing there takes much longer due to the fetching and validation of Merkle proofs. There are ongoing BDK changes in relation to that and so we can further upgrade this dependency once those changes have been completed. Non-BDK changes to the liana and lianad crates are taken from darosior's commit 20ee8b1 in draft PR wizardsardine#1228.
jp1ac4
force-pushed
the
prev-bdk-update-bitcoin
branch
from
cddd3b2 to
c5f5284
Compare
|
Rebased on master and updated async_hwi depedency to v0.0.26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to upgrade bitcoin to 0.32 and related dependencies accordingly.
Note that the bdk_electrum crate has not been upgraded to the most recent version available as the Electrum syncing there takes much longer due to the fetching and validation of Merkle proofs. There are ongoing changes in relation to that (bitcoindevkit/bdk#1699) and so we can further upgrade this dependency once those changes have been completed.
Non-BDK changes to the liana and lianad crates are taken from commit 20ee8b1 in draft PR #1228, which this replaces.
(Once this PR has been tested and approved, we can release a new version of the async_hwi crate and point to that.)