Refine setTimeout by const reference

wjwwood · Aug 21, 2019 · 907b9f4 · 907b9f4
1 parent 683e12d
commit 907b9f4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/include/serial/impl/unix.h b/include/serial/impl/unix.h
@@ -141,7 +141,7 @@ class serial::Serial::SerialImpl {
   getPort () const;
 
   void
-  setTimeout (Timeout &timeout);
+  setTimeout (const Timeout &timeout);
 
   Timeout
   getTimeout () const;

diff --git a/include/serial/impl/win.h b/include/serial/impl/win.h
@@ -130,7 +130,7 @@ class serial::Serial::SerialImpl {
   getPort () const;
 
   void
-  setTimeout (Timeout &timeout);
+  setTimeout (const Timeout &timeout);
 
   Timeout
   getTimeout () const;

diff --git a/include/serial/serial.h b/include/serial/serial.h
@@ -458,7 +458,7 @@ class Serial {
    * \see serial::Timeout
    */
   void
-  setTimeout (Timeout &timeout);
+  setTimeout (const Timeout &timeout);
 
   /*! Sets the timeout for reads and writes. */
   void

diff --git a/src/impl/unix.cc b/src/impl/unix.cc
@@ -707,7 +707,7 @@ Serial::SerialImpl::getPort () const
 }
 
 void
-Serial::SerialImpl::setTimeout (serial::Timeout &timeout)
+Serial::SerialImpl::setTimeout (const serial::Timeout &timeout)
 {
   timeout_ = timeout;
 }

diff --git a/src/impl/win.cc b/src/impl/win.cc
@@ -370,7 +370,7 @@ Serial::SerialImpl::getPort () const
 }
 
 void
-Serial::SerialImpl::setTimeout (serial::Timeout &timeout)
+Serial::SerialImpl::setTimeout (const serial::Timeout &timeout)
 {
   timeout_ = timeout;
   if (is_open_) {

diff --git a/src/serial.cc b/src/serial.cc
@@ -295,7 +295,7 @@ Serial::getPort () const
 }
 
 void
-Serial::setTimeout (serial::Timeout &timeout)
+Serial::setTimeout (const serial::Timeout &timeout)
 {
   pimpl_->setTimeout (timeout);
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -707,7 +707,7 @@ Serial::SerialImpl::getPort () const @@
     }
     void
-    Serial::SerialImpl::setTimeout (serial::Timeout &timeout)
+    Serial::SerialImpl::setTimeout (const serial::Timeout &timeout)
     {
       timeout_ = timeout;
     }
@@ Expand Down @@