Proposed solution for issue 101 #102
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timeout by const reference (Addresses issue wjwwood#101)
|
The pull request looks good to me, but I need to think about when to release it since it touches the public API. |
|
Glad it looks good, and btw I'm in no rush for the fix. It's worth noting that while this is a change to public API (it breaks binary ABI), I believe it's a guaranteed non-breaking change at the code level. That is, I can't think of any use case where code that worked previously would not work with this PR. It is always safe to treat a non-const reference (the previous code) as a const ref (the new code). Thanks again for your support with and attention to the matter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to
Serial::setTimeout(and unix/win implementations) to accept timeout by const reference, see: #101.I do not have this repo building but these changes building right now, but figured the changes were minor and limited enough to do them just by eyeballing them. I hope that this PR is acceptable. If not, let me know and I'll see what I can do to make it so.
Thank