-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add own background image upload #3596
Conversation
I'll share this image from @dosipod as I am not sure storing image in browser local storage is good or not, but I can't find the justification for increased file/code size. |
The code size increased by 176 Bytes.
Now:
In the picture, the image was stored on the ESP’s filesystem. Given the limited space available on the ESP’s filesystem, it can only accommodate very small images. Therefore, I believe that utilizing localStorage for storing the image would be a more efficient approach compared to the ESP’s filesystem. As far as I’m aware, there are no significant drawbacks to storing an image in localStorage. The only potential issue is that the |
In last 30 days we added almost 12kB into UI alone. |
We moved simple UI to index page, this increased the size a lot. |
True, and iro and color picker too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this as it allows for custom backgrounds without utilizing very limited ESP resources or having to host and download the image from some external server!
Merging.
Thanks! Another point that came to my mind: Also, when using WLED in AP mode, you can't download the image from an external server because you don't have Internet access. So now you can also set your own background image in AP mode. |
This adds the feature to upload your own background image.

If you select an image, it will be base64 encoded and then set as the background url.
Limitations:

The maximum size of the image depends on the maximum size of your browser's local storage. Usually browsers can store up to 5 MiB of local storage. If you try to use an image that is too large, you will get this error: