Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dialyzer warnings #21

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/basic/NumberAdder.ex
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
defmodule NumberAdder do
@on_load :init
def init(), do: :erlang.load_nif(to_charlist(Path.join(Path.dirname(__ENV__.file), 'libnif')), 0)
def init(),
do: :erlang.load_nif(to_charlist(Path.join(Path.dirname(__ENV__.file), 'libnif')), 0)

def add_numbers(_, _), do: exit(:nif_library_not_loaded)
def sub_numbers(_, _), do: exit(:nif_library_not_loaded)
def add_numbers(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def sub_numbers(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
end
4 changes: 2 additions & 2 deletions nimler/gen_module.nim
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $4
end
"""
const elixirFn = """
def $1($2), do: exit(:nif_library_not_loaded)
def $1($2), do: :erlang.nif_error(:nif_library_not_loaded)
"""

const erlangModule = """
Expand All @@ -35,7 +35,7 @@ $4
$5
"""
const erlangFn = """
$1($2) -> exit(nif_library_not_loaded).
$1($2) -> :erlang.nif_error(:nif_library_not_loaded).
"""

proc genFn(templ: string, fn: ErlNifFunc): string {.compileTime.} =
Expand Down
43 changes: 23 additions & 20 deletions tests/codec/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,25 +1,28 @@
defmodule NimlerCodec do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def codec_options(_, _), do: exit(:nif_library_not_loaded)
def codec_int(_, _), do: exit(:nif_library_not_loaded)
def codec_int32(_, _), do: exit(:nif_library_not_loaded)
def codec_uint32(_, _), do: exit(:nif_library_not_loaded)
def codec_uint64(_), do: exit(:nif_library_not_loaded)
def codec_double(_), do: exit(:nif_library_not_loaded)
def codec_atom(_), do: exit(:nif_library_not_loaded)
def codec_charlist(_), do: exit(:nif_library_not_loaded)
def codec_string(_), do: exit(:nif_library_not_loaded)
def codec_binary(_), do: exit(:nif_library_not_loaded)
def codec_list_int(_), do: exit(:nif_library_not_loaded)
def codec_list_string(_), do: exit(:nif_library_not_loaded)
def codec_tuple(_), do: exit(:nif_library_not_loaded)
def codec_map(_, _, _), do: exit(:nif_library_not_loaded)
def codec_keywords(_), do: exit(:nif_library_not_loaded)
def codec_result_ok(_), do: exit(:nif_library_not_loaded)
def codec_result_error(_), do: exit(:nif_library_not_loaded)

def codec_options(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_int(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_int32(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_uint32(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_uint64(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_double(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_atom(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_charlist(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_string(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_binary(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_list_int(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_list_string(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_tuple(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_map(_, _, _), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_keywords(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_result_ok(_), do: :erlang.nif_error(:nif_library_not_loaded)
def codec_result_error(_), do: :erlang.nif_error(:nif_library_not_loaded)
end
13 changes: 8 additions & 5 deletions tests/dirty_nif/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
defmodule NimlerDirtyNif do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def dirty_cpu(), do: exit(:nif_library_not_loaded)
def dirty_io(), do: exit(:nif_library_not_loaded)

def dirty_cpu(), do: :erlang.nif_error(:nif_library_not_loaded)
def dirty_io(), do: :erlang.nif_error(:nif_library_not_loaded)
end
15 changes: 9 additions & 6 deletions tests/init_api/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
defmodule NimlerInitApi do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 123)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
123
)

def test(), do: exit(:nif_library_not_loaded)
def test_priv(), do: exit(:nif_library_not_loaded)
def test_dirty(), do: exit(:nif_library_not_loaded)

def test(), do: :erlang.nif_error(:nif_library_not_loaded)
def test_priv(), do: :erlang.nif_error(:nif_library_not_loaded)
def test_dirty(), do: :erlang.nif_error(:nif_library_not_loaded)
end
15 changes: 9 additions & 6 deletions tests/init_resource/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
defmodule NimlerInitResource do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def new(), do: exit(:nif_library_not_loaded)
def set(_, _), do: exit(:nif_library_not_loaded)
def check(_, _), do: exit(:nif_library_not_loaded)

def new(), do: :erlang.nif_error(:nif_library_not_loaded)
def set(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def check(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
end
149 changes: 76 additions & 73 deletions tests/integration/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,78 +1,81 @@
defmodule NimlerIntegration do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def is_atom(_), do: exit(:nif_library_not_loaded)
def is_binary(_), do: exit(:nif_library_not_loaded)
def is_current_process_alive(), do: exit(:nif_library_not_loaded)
def is_empty_list(_), do: exit(:nif_library_not_loaded)
def is_exception(_), do: exit(:nif_library_not_loaded)
def is_fun(_), do: exit(:nif_library_not_loaded)
def is_identical(_, _), do: exit(:nif_library_not_loaded)
def is_list(_), do: exit(:nif_library_not_loaded)
def is_map(_), do: exit(:nif_library_not_loaded)
def is_number(_), do: exit(:nif_library_not_loaded)
def is_pid(_), do: exit(:nif_library_not_loaded)
def is_pid_undefined(_), do: exit(:nif_library_not_loaded)
def is_process_alive(_), do: exit(:nif_library_not_loaded)
def is_ref(_), do: exit(:nif_library_not_loaded)
def is_tuple(_), do: exit(:nif_library_not_loaded)
def get_atom(_), do: exit(:nif_library_not_loaded)
def get_atom_length(_), do: exit(:nif_library_not_loaded)
def get_string(_), do: exit(:nif_library_not_loaded)
def get_int(_), do: exit(:nif_library_not_loaded)
def get_long(_), do: exit(:nif_library_not_loaded)
def get_int64(_), do: exit(:nif_library_not_loaded)
def get_uint(_), do: exit(:nif_library_not_loaded)
def get_ulong(_), do: exit(:nif_library_not_loaded)
def get_uint64(_), do: exit(:nif_library_not_loaded)
def get_double(_), do: exit(:nif_library_not_loaded)
def get_tuple(_), do: exit(:nif_library_not_loaded)
def get_list_length(_), do: exit(:nif_library_not_loaded)
def get_list_cell(_), do: exit(:nif_library_not_loaded)
def get_map_size(_), do: exit(:nif_library_not_loaded)
def get_map_value(_, _), do: exit(:nif_library_not_loaded)
def get_local_pid(_), do: exit(:nif_library_not_loaded)
def make_map_put(_, _, _), do: exit(:nif_library_not_loaded)
def make_map_remove(_, _), do: exit(:nif_library_not_loaded)
def make_map_update(_, _, _), do: exit(:nif_library_not_loaded)
def make_string(), do: exit(:nif_library_not_loaded)
def make_string_len(), do: exit(:nif_library_not_loaded)
def make_list(), do: exit(:nif_library_not_loaded)
def make_list_cell(), do: exit(:nif_library_not_loaded)
def make_list_from_array(), do: exit(:nif_library_not_loaded)
def make_reverse_list(_), do: exit(:nif_library_not_loaded)
def make_tuple(), do: exit(:nif_library_not_loaded)
def make_tuple_from_array(), do: exit(:nif_library_not_loaded)
def make_int(), do: exit(:nif_library_not_loaded)
def make_long(), do: exit(:nif_library_not_loaded)
def make_int64(), do: exit(:nif_library_not_loaded)
def make_uint(), do: exit(:nif_library_not_loaded)
def make_ulong(), do: exit(:nif_library_not_loaded)
def make_uint64(), do: exit(:nif_library_not_loaded)
def make_double(), do: exit(:nif_library_not_loaded)
def make_new_binary(), do: exit(:nif_library_not_loaded)
def make_new_map(), do: exit(:nif_library_not_loaded)
def make_map_from_arrays(), do: exit(:nif_library_not_loaded)
def make_atom(), do: exit(:nif_library_not_loaded)
def make_existing_atom(), do: exit(:nif_library_not_loaded)
def make_existing_atom_len(), do: exit(:nif_library_not_loaded)
def make_copy(), do: exit(:nif_library_not_loaded)
def make_pid(), do: exit(:nif_library_not_loaded)
def make_ref(), do: exit(:nif_library_not_loaded)
def make_unique_integer(), do: exit(:nif_library_not_loaded)
def e_compare(_, _), do: exit(:nif_library_not_loaded)
def term_type(_, _, _, _, _, _), do: exit(:nif_library_not_loaded)
def system_info(), do: exit(:nif_library_not_loaded)
def e_raise_exception(_), do: exit(:nif_library_not_loaded)
def e_monotonic_time(), do: exit(:nif_library_not_loaded)
def e_convert_time_unit(), do: exit(:nif_library_not_loaded)
def e_time_offset(), do: exit(:nif_library_not_loaded)
def e_cpu_time(), do: exit(:nif_library_not_loaded)
def e_now_time(), do: exit(:nif_library_not_loaded)
def e_fprintf(), do: exit(:nif_library_not_loaded)
def e_snprintf(), do: exit(:nif_library_not_loaded)

def is_atom(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_binary(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_current_process_alive(), do: :erlang.nif_error(:nif_library_not_loaded)
def is_empty_list(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_exception(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_fun(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_identical(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def is_list(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_map(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_number(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_pid(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_pid_undefined(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_process_alive(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_ref(_), do: :erlang.nif_error(:nif_library_not_loaded)
def is_tuple(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_atom(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_atom_length(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_string(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_int(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_long(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_int64(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_uint(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_ulong(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_uint64(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_double(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_tuple(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_list_length(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_list_cell(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_map_size(_), do: :erlang.nif_error(:nif_library_not_loaded)
def get_map_value(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def get_local_pid(_), do: :erlang.nif_error(:nif_library_not_loaded)
def make_map_put(_, _, _), do: :erlang.nif_error(:nif_library_not_loaded)
def make_map_remove(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def make_map_update(_, _, _), do: :erlang.nif_error(:nif_library_not_loaded)
def make_string(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_string_len(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_list(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_list_cell(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_list_from_array(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_reverse_list(_), do: :erlang.nif_error(:nif_library_not_loaded)
def make_tuple(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_tuple_from_array(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_int(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_long(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_int64(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_uint(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_ulong(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_uint64(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_double(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_new_binary(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_new_map(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_map_from_arrays(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_atom(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_existing_atom(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_existing_atom_len(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_copy(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_pid(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_ref(), do: :erlang.nif_error(:nif_library_not_loaded)
def make_unique_integer(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_compare(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def term_type(_, _, _, _, _, _), do: :erlang.nif_error(:nif_library_not_loaded)
def system_info(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_raise_exception(_), do: :erlang.nif_error(:nif_library_not_loaded)
def e_monotonic_time(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_convert_time_unit(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_time_offset(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_cpu_time(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_now_time(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_fprintf(), do: :erlang.nif_error(:nif_library_not_loaded)
def e_snprintf(), do: :erlang.nif_error(:nif_library_not_loaded)
end
13 changes: 8 additions & 5 deletions tests/message/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
defmodule NimlerMessage do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def send_message(_, _), do: exit(:nif_library_not_loaded)
def send_message_caller(_), do: exit(:nif_library_not_loaded)

def send_message(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def send_message_caller(_), do: :erlang.nif_error(:nif_library_not_loaded)
end
33 changes: 18 additions & 15 deletions tests/positional/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
defmodule NimlerPositionalArgs do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def pos_int(_, _), do: exit(:nif_library_not_loaded)
def pos_bool(_, _, _, _), do: exit(:nif_library_not_loaded)
def pos_bin(_), do: exit(:nif_library_not_loaded)
def pos_str(_), do: exit(:nif_library_not_loaded)
def pos_charlist(_), do: exit(:nif_library_not_loaded)
def pos_seq(_), do: exit(:nif_library_not_loaded)
def pos_map(_), do: exit(:nif_library_not_loaded)
def pos_tup_map(_), do: exit(:nif_library_not_loaded)
def pos_pid(_, _), do: exit(:nif_library_not_loaded)
def pos_ok?(_), do: exit(:nif_library_not_loaded)
def pos_keywords(_), do: exit(:nif_library_not_loaded)
def pos_result(_, _), do: exit(:nif_library_not_loaded)

def pos_int(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_bool(_, _, _, _), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_bin(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_str(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_charlist(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_seq(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_map(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_tup_map(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_pid(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_ok?(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_keywords(_), do: :erlang.nif_error(:nif_library_not_loaded)
def pos_result(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
end
15 changes: 9 additions & 6 deletions tests/resource/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
defmodule NimlerWrapper do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def create_resource(), do: exit(:nif_library_not_loaded)
def update_resource(_), do: exit(:nif_library_not_loaded)
def check_resource(_), do: exit(:nif_library_not_loaded)

def create_resource(), do: :erlang.nif_error(:nif_library_not_loaded)
def update_resource(_), do: :erlang.nif_error(:nif_library_not_loaded)
def check_resource(_), do: :erlang.nif_error(:nif_library_not_loaded)
end
11 changes: 7 additions & 4 deletions tests/timeslice/NimlerWrapper.ex
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
defmodule NimlerTimeslice do
@on_load :init

def init(), do: :erlang.load_nif(to_charlist(
Path.join(Path.dirname(__ENV__.file), 'nif')), 0)
def init(),
do:
:erlang.load_nif(
to_charlist(Path.join(Path.dirname(__ENV__.file), 'nif')),
0
)

def test_consume_timeslice(_, _), do: exit(:nif_library_not_loaded)

def test_consume_timeslice(_, _), do: :erlang.nif_error(:nif_library_not_loaded)
end