-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports marshaling of nested IEs #18
base: master
Are you sure you want to change the base?
Conversation
@wmnsk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide the example of payload that this PR will make it possible to handle? 💯 if you can add it to the test case in codec_test.go.
What is the point in returning "Decoded Length is not equal to..."
error? In which situation would it happen, and can it be avoided somehow?
Yes, I'll add an example as a test case! But basically it allows you to construct a tree of IEs (IEs containing other IEs) and then marshaling them, without having to manually inject the inner IEs encoded into the outer IEs's Value field.
This error helped me while developing this PR, and I'm sure it could help us catch parsing errors in the wild, and could make potentiel bug reports a bit more readable of what happened in case of issues. Thanks a lot for your time on such a niche but awesome library :-) |
Test case added and rebased upon new commit of PR #17, thanks a lot! |
Depends on #17
WIP, unit tests to be fixed.