Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSSE: correct SSLSocket exception types, fix for setting fd #228

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

cconlon
Copy link
Member

@cconlon cconlon commented Oct 30, 2024

A previous PR (#222) had introduced an internal helper method (checkAndInitSSLSocket()) to help make sure the SSLSocket was initialized and native file descriptor set. This PR makes two small fixes:

  • Corrects the expected exception thrown from getInputStream() and getOutputStream() from IOException to SocketException.
  • Adds an independent flag indicating if the native fd has been set or not. This allows code to initialize the cert/key, and later come back and set the file descriptor once the socket is connected.

This PR fixes our nightly Jenkins SunJSSE test.

@JacobBarthelmeh JacobBarthelmeh merged commit 30e4042 into wolfSSL:master Nov 1, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants