Remove automatic SNI extension fallback in WolfSSLEngineHelper #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only set Server Name Indication (SNI) extension when explicitly configured through SSLParameters. Remove automatic fallback logic that would set SNI based on hostname or peer address, as this could cause unexpected behavior and test failures. This change: - Fixes test failures in SSLSocketExplorerWithSrvSNI - Improves compatibility with standard JSSE behavior - Adds debug logging when SNI is not configured
|
I'm a little hesitant about this change, since I want to say we have had customers with failing connections until this behavior was added. Are we sure that SunJSSE only sets the SNI extension in the ClientHello when set in the SSLParameters, and doesn't pick it up if the SSLSocket is created using certain inputs? Also, did we decide that this did indeed fix the Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set Server Name Indication (SNI) extension when explicitly configured through SSLParameters. Remove automatic fallback logic that would set SNI based on hostname or peer address, as this could cause unexpected behavior and test failures.
This change: