Hotfix | #81 | @YongsHub | v1.0.1 출시 위해 Query Transform 리팩토링 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YongsHub
had a problem deploying
to
Development-CI
GitHub Actions
Failure
lcomment
approved these changes
Feb 28, 2024
|
|
||
| import com.lovebird.domain.dto.query.DiaryResponseParam | ||
|
|
||
| data class DiarySimpleResponse( |
There was a problem hiding this comment.
갑자기 네이밍을 바꾸신 특별한 이유가 있으실까요?
There was a problem hiding this comment.
DiaryResponse와 DiarySimpleResponse의 return value들이 기존에 달랐던걸 인지하지 못하고 통합해버려서 원래대로 다시 분리했습니다!
|
CI에서 패키지 import 순서 관련 ktlint 에러 났네요 ~ 확인해주세요 ~ |
YongsHub
had a problem deploying
to
Development-CI
GitHub Actions
Failure
YongsHub
had a problem deploying
to
Development-CI
GitHub Actions
Failure
YongsHub
temporarily deployed
to
Development-CI
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81