Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use curl instead of cr #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use curl instead of cr #289

wants to merge 1 commit into from

Conversation

pat-s
Copy link
Collaborator

@pat-s pat-s commented Jan 9, 2025

More issues than help. Broke again after the most recent 1.7 release when releasing chart 2.0.4.

A curl command to upload to create a GH release directly should be more resilient.

@pat-s pat-s added the build label Jan 9, 2025
@pat-s pat-s requested a review from xoxys January 9, 2025 23:27
@xoxys
Copy link
Member

xoxys commented Jan 10, 2025

Compared to cr its really unreadable 🙈 whats the current issue with the latest cr release? Just stick with the working version for now if its a known bug?

@pat-s
Copy link
Collaborator Author

pat-s commented Jan 10, 2025

Well, cr is also not really readable (why does it need like five flags to do a simple gh-pages publish?) and in the end it is only doing an API call to the GH releases endpoint anyway.

Personally, I'd drop the gh-pages upload entirely.
I am absolutely unhappy maintaining cr solely for this purpose. In all environments/projects I've used in the last 3 years it broke for almost every point release (and in between). In addition, I don't see why one would need an additional packaging wrapper just for helm charts. The OCI variant shows how easy a chart release can be and is on top using helm itself.

So: either somebody else commits to maintain cr from here onward or we drop it. Overall I'd prefer dropping the upload to gh-pages entirely and just keep the OCI variant (and yes I know this is breaking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants