test: 코드 리뷰 테스트 #31
Closed
test: 코드 리뷰 테스트 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| public static void main(String[] args) { | ||
| new Thread(() -> { | ||
| while (!flag) { |
There was a problem hiding this comment.
r: while (!flag) 루프는 무한 루프가 될 수 있으며, flag가 변경될 때까지 대기하는 것은 비효율적입니다. flag가 변경될 때까지 대기하는 방법을 개선해야 합니다.
| new Thread(() -> { | ||
| while (!flag) { | ||
| } | ||
| System.out.println("value: " + value); |
There was a problem hiding this comment.
c: System.out.println 대신 로깅 프레임워크를 사용하는 것이 좋습니다. 이는 코드의 유지보수성을 높이고, 로그 레벨을 조정할 수 있는 장점이 있습니다.
| }).start(); | ||
|
|
||
| new Thread(() -> { | ||
| value = 42; |
There was a problem hiding this comment.
c: value와 flag의 접근을 동기화해야 합니다. 현재 상태에서는 멀티스레드 환경에서 데이터 일관성이 보장되지 않습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
RCA 룰
| 코드 리뷰 멘토가 PR작성자에게 어떤 의도로 전달 되길 바라는지 알파벳으로 표현해주세요!