Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next page bug on search #340

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Oct 26, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

When next page request, entities that do not matched conditions are searched.

What is the new behavior?

The next page of the search contains unnecessary conditions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr added the bug Something isn't working label Oct 26, 2023
@jiho-kr jiho-kr self-assigned this Oct 26, 2023
@jiho-kr jiho-kr force-pushed the feature/search-bug branch from c49319d to c3a5841 Compare October 26, 2023 07:36
@jiho-kr jiho-kr merged commit 6f71931 into woowabros:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants