Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use crypto.getRandomValues instead of Math.random #387

Merged
merged 1 commit into from
Dec 16, 2023
Merged

feat: use crypto.getRandomValues instead of Math.random #387

merged 1 commit into from
Dec 16, 2023

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Dec 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

image

What is the new behavior?

use crypto.getRandomValues instead of Math.random

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr requested a review from Pigrabbit December 15, 2023 07:38
@jiho-kr jiho-kr self-assigned this Dec 15, 2023
@jiho-kr jiho-kr merged commit 906cf0f into woowabros:main Dec 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pigrabbit Pigrabbit Pigrabbit approved these changes

Assignees

@jiho-kr jiho-kr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiho-kr @Pigrabbit