feat: support Entity Inheritance #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiho-kr
force-pushed
the
feature/entity-inheritance
branch
from
47e28eb to
63a4d23
Compare
10 tasks
Pigrabbit
reviewed
Dec 18, 2023
Comment on lines
+98
to
+108
| const tableName = (() => { | ||
| const table = getMetadataArgsStorage().tables.find(({ target }) => target === entity); | ||
| if (!table) { | ||
| throw new Error('Cannot find Table from TypeORM'); | ||
| } | ||
| if (!table.name && table.type === 'entity-child') { | ||
| const discriminatorValue = getMetadataArgsStorage().discriminatorValues.find(({ target }) => target === entity)?.value; | ||
| return typeof discriminatorValue === 'string' ? discriminatorValue : discriminatorValue?.name; | ||
| } | ||
| return table.name; | ||
| })(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #389
What is the new behavior?
Support @ChildEntity (Typeorm Entity Inheritance)
Does this PR introduce a breaking change?
Other information