Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts2742 #397

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: ts2742 #397

merged 1 commit into from
Dec 19, 2023

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Dec 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

src/lib/interceptor/upsert-request.interceptor.ts:12:17 - error TS2742: The inferred type of 'UpsertRequestInterceptor' cannot be named without a reference to 'express-serve-static-core/node_modules/@types/qs'. This is likely not portable. A type annotation is necessary.

12 export function UpsertRequestInterceptor(crudOptions: CrudOptions, factoryOption: FactoryOption) {

deprecated toThrowError

        /**
         * If you want to test that a specific error is thrown inside a function.
         *
         * @deprecated in favor of `toThrow`
         */
        toThrowError(error?: string | Constructable | RegExp | Error): R;

What is the new behavior?

resolved typescript error

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr self-assigned this Dec 19, 2023
@jiho-kr jiho-kr merged commit 32321d0 into woowabros:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants