Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Searching with parameters is not used when the body is empty. #642

Merged
merged 19 commits into from
Aug 29, 2024

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Aug 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

Searching with parameters is not used when the body is empty.

What is the new behavior?

should be search with parameters with or without body

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr added the bug Something isn't working label Aug 29, 2024
@jiho-kr jiho-kr self-assigned this Aug 29, 2024
@jiho-kr jiho-kr changed the title fix: Searching with parameters is not used when the body is empty. WIP: fix: Searching with parameters is not used when the body is empty. Aug 29, 2024
Copy link
Contributor

@Pigrabbit Pigrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏼

@jiho-kr jiho-kr force-pushed the feature/search-params branch from 3a10636 to 7c096dc Compare August 29, 2024 04:24
@jiho-kr jiho-kr changed the title WIP: fix: Searching with parameters is not used when the body is empty. fix: Searching with parameters is not used when the body is empty. Aug 29, 2024
@jiho-kr jiho-kr merged commit e9263e9 into woowabros:main Aug 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants