Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options #550

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Remove deprecated options #550

merged 5 commits into from
Feb 28, 2024

Conversation

spencertransier
Copy link
Contributor

What does it do?

  • Removed deprecated has_alpha_version, project_name, and project_root_folder options from several actions in preparation for the 10.0 Release Toolkit release.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
    - [ ] Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@spencertransier spencertransier requested a review from a team February 28, 2024 09:58
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just remove this file completely. deprecated.rb could be added back later if needed, but I thought it didn't make sense to keep around an empty file indefinitely.

@spencertransier spencertransier merged commit 2c46606 into trunk Feb 28, 2024
5 checks passed
@spencertransier spencertransier deleted the remove/deprecated-code branch February 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants