Roi for tags #7645
Roi for tags #7645
Conversation
upstream_utils/clone
Outdated
upstream_utils/reset
Outdated
| @@ -86,6 +95,7 @@ void AprilTagDetector::SetQuadThresholdParameters( | |||
| qtp.max_line_fit_mse = params.maxLineFitMSE; | |||
| qtp.min_white_black_diff = params.minWhiteBlackDiff; | |||
| qtp.deglitch = params.deglitch; | |||
|
|
|||
There was a problem hiding this comment.
Remove the spurious newlines added in this PR.
| for (int y = 0; y < orig->height; y++) { | ||
| for (int x = 0; x < orig->width; x++) { | ||
|
|
||
| //TO-DO add check of roiX and roiY |
There was a problem hiding this comment.
Are these going to be done in this PR? If so, this PR should be marked as a draft.
Also, IDEs typically highlight TODO instead of TO-DO.
A space should be included between // and its content.
There was a problem hiding this comment.
Excuse me I didn't quite understand what you want with this one, I just marked it for me to remember, I can delete it if that's a problem but I intent on making it part of the PR
There was a problem hiding this comment.
Since you still have more to add, I'll convert this PR to a draft.
|
What does ROI mean in this context? |
Based on #7583 (which was opened by the same person), I would guess Region Of Interest? I'd still want to hear confirmation from the PR author though. |
Yes hi, I want to implement a ROI for the tasks that process the image at C level, x,y,w,h which will shorten processing time |
There was a problem hiding this comment.
You should combine patches 9 through 12 into one commit. (Follow https://github.com/wpilibsuite/allwpilib/blob/main/upstream_utils/README.md#adding-patch-to-thirdparty-library, but instead of making a commit, run git rebase -i 3806edf38ac4400153677e510c9f9dcb81f472c8 and replace "pick" with "fixup" at the start of the lines with "fixed names for roi variables", "change names of roi variables", and "test".
…that were detected outside of the wanted region Need to polish it a bit but the main thing is that I only filter quads after they detected because I tried to make changes into the code itself with starting the iterators and until from given ROI variables
|
I will address your comments but I want to finish the code first before managing all the things around it, there are still ways to save on processing time if anyone could help It would be gladly appreciated |
This is a ROI implementation for the Apriltags detector to lower processing time