Add PlayingWithFusion Packages #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a lot of issues here. The devs should really take a look at the checker logs. |
Bummer, I can let the developers know of the issue. I just looked at the check and there's a lot going on. |
|
We (Playing With Fusion) are still testing out the 2025 library. We're not ready to publicly release yet |
Apologies for the mix-up - This is entirely my fault. I mistakenly assumed the package was a public release and uploaded it to the vendor JSON. I appreciate your clarification and understand you're still testing—thank you for letting me know. |
|
No worries at all. I appreciate the help. It took me a minute to figure out what happened. You branch was almost identical to mine. I thought there was some sort of GitHub magic that automatically created your PR.
Testing on the RIO is complete from our end, but vendor-json-repo automation seems annoyed that all of the PlayingWithFusion classes are in the frc namespace, so that’s going to cause me to build a version 2025.01.04
You’re fine to keep using 2025.01.03, it will be functionally equivalent to 2025.01.04. The only change you’ll see is the CANVenom, TimeOfFlight, & TMD37003 classes moving into the pwf namespace instead of frc.
Thanks,
Jared
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been emailing the PlayingWithFusion developers as they didn't have the package released for the 2025 season initially on kickoff. They just released it today, so I figured I would add it to the WPILib Vendor JSON so that everyone can access it. It's kinda hard to find on their website.
This package is used for the Venom motors and the sensors that they provide on their website.
I did want to note that on my commit "yep" I changed the file name from playingwithfusion2024 to 2025 as I noticed that they didn't do that on their release. Works on our robot, however, so I believe this is fine.
Hopefully, I did this alright, please let me know if I messed something up. I'm more than happy to correct my mistake.