Add document link to emails for guest customers

[MohamadNateqi]

close #1035

[alexmigf]

Some remarks:

• This setting does not need to trigger a Preview refresh.
• It might be useful to allow selecting the email template hook where the link is displayed.
• Instead of disabling the field, we could display it only when the "Guest" access type is enabled. In this case, we would also need to update the field description.

[MohamadNateqi]

@alexmigf

It might be useful to allow selecting the email template hook where the link is displayed.

Do you suggest such a setting:

It's a multiselect to allow choosing several hooks.

Instead of disabling the field, we could display it only when the "Guest" access type is enabled. In this case, we would also need to update the field description.

I thought this way, customers would know that such a setting exists easily.
So, do you believe hiding it and adding a description for the access type setting to inform about this feature would be better?

[alexmigf]

It's a multiselect to allow choosing several hooks.

I believe a standard selector is more appropriate since the user is unlikely to select more than one option.

I thought this way, customers would know that such a setting exists easily.
So, do you believe hiding it and adding a description for the access type setting to inform about this feature would be better?

I understand your point, but I believe we should avoid promoting the "Guest" access type, as it is less secure. Customers already using "Guest" will see the option, and I believe they are the intended target.

[alexmigf]

In summary, I don't think we should use the terms "guest emails" and "Download invoice," as I believe neither fully reflects the actual concepts.

[alexmigf]

LGTM!