perf(core): ⚡ improve code

improve code ref: #336
wrappid · Aug 29, 2024 · 6854a11 · 6854a11
1 parent eadfe54
commit 6854a11
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 27 deletions.
diff --git a/package/components/dataDisplay/CoreTable.js b/package/components/dataDisplay/CoreTable.js
@@ -4,33 +4,13 @@ import React from "react";
 
 import { NativeTable } from "@wrappid/native";
 
-import { getUUID } from "../../utils/appUtils";
 import { sanitizeComponentProps } from "../../utils/componentUtil";
 
 export default function CoreTable(props) {
-  let _uuid = getUUID();
-  // eslint-disable-next-line no-unused-vars
-  let containerId = props?.coreId ? "tc_" + props.coreId : "tc_" + _uuid;
-
   props = sanitizeComponentProps(CoreTable, props);
 
-  const {
-    children,
-    component,
-    padding,
-    size,
-    stickyHeader,
-  } = props;
-
   return (
-    <NativeTable
-      component={component}
-      padding={padding}
-      size={size}
-      stickyHeader={stickyHeader}
-    >
-      {children}
-    </NativeTable>
+    <NativeTable {...props} />
   );
 }
 

diff --git a/package/components/dataDisplay/CoreTableBody.js b/package/components/dataDisplay/CoreTableBody.js
@@ -8,7 +8,7 @@ import { sanitizeComponentProps } from "../../utils/componentUtil";
 
 export default function CoreTableBody(props) {
   props = sanitizeComponentProps(CoreTableBody, props);
-  return <NativeTableBody {...props}>{props?.children}</NativeTableBody>;
+  return <NativeTableBody {...props} />;
 }
 
 CoreTableBody.displayName = "CoreTableBody";

diff --git a/package/components/dataDisplay/CoreTableContainer.js b/package/components/dataDisplay/CoreTableContainer.js
@@ -8,7 +8,7 @@ import { sanitizeComponentProps } from "../../utils/componentUtil";
 
 export default function CoreTableContainer(props) {
   props = sanitizeComponentProps(CoreTableContainer, props);
-  return <NativeTableContainer {...props}>{props?.children}</NativeTableContainer>;
+  return <NativeTableContainer {...props} />;
 }
 
 CoreTableContainer.displayName = "CoreTableContainer";

diff --git a/package/components/dataDisplay/CoreTableFooter.js b/package/components/dataDisplay/CoreTableFooter.js
@@ -8,7 +8,7 @@ import { sanitizeComponentProps } from "../../utils/componentUtil";
 
 export default function CoreTableFooter(props) {
   props = sanitizeComponentProps(CoreTableFooter, props);
-  return <NativeTableFooter {...props}>{props?.children}</NativeTableFooter>;
+  return <NativeTableFooter {...props} />;
 }
 CoreTableFooter.displayName = "CoreTableFooter";
 CoreTableFooter.validProps = [

diff --git a/package/components/dataDisplay/CoreTablePagination.js b/package/components/dataDisplay/CoreTablePagination.js
@@ -8,14 +8,21 @@ import CoreTableCell from "./CoreTableCell";
 import { DATA_TABLE_CONST } from "../../config/dataTableConstants";
 import { sanitizeComponentProps } from "../../utils/componentUtil";
 
+/**
+ * CoreTablePagination is a component that displays pagination controls for a table.
+ * @todo rowsPerPageOptions via wrappid style context.
+ * @param {*} props 
+ * @returns 
+ */
 export default function CoreTablePagination(props) {
   props = sanitizeComponentProps(CoreTablePagination, props);
+  const { rowsPerPageOptions, ...restProps } = props;
+
   return (
     <NativeTablePagination
-      component={"div"}
       labelRowsPerPage="" // make it clean
-      rowsPerPageOptions={DATA_TABLE_CONST.ROWS_PER_PAGE_OPTIONS}
-      {...props}
+      rowsPerPageOptions={rowsPerPageOptions || DATA_TABLE_CONST.ROWS_PER_PAGE_OPTIONS}
+      {...restProps}
     />
   );
 }