refactor: 🐛 run wr fetch command in the module #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anantakumarghosh
changed the title
anantakumarghosh
force-pushed
the
RXFY-refactor-25
branch
from
f723042 to
63e5875
Compare
techoneel
requested changes
Feb 5, 2024
| dispatch({ type: GET_PROFILE_BASIC_LOADING }); | ||
| let newUrl = ApiRegistry.GET_PROFILE_BASIC_API; | ||
|
|
||
| fetch(backendUrl + newUrl, { |
There was a problem hiding this comment.
fetch shouldn't be used directly we have apiRequestAction for that from @wrappid/core - https://github.com/wrappid/core/blob/ccb6b40252dfaa7daa7438b3ff3c920eccade49a/package/store/action/appActions.js#L41
PritamIT2023
pushed a commit
that referenced
this pull request
Feb 19, 2024
refactor: service folder move to typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run
wr fetchcommand in the moduleRef: rxefy/profile-module #25
Refer Original PR #27